[webkit-reviews] review denied: [Bug 40245] [Qt] DragClientQt.h has coding-style errors : [Attachment 58057] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 40245: [Qt] DragClientQt.h has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40245

Attachment 58057: Patch
https://bugs.webkit.org/attachment.cgi?id=58057&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
> index
fd58b69e86393a34b81a1a00816128f063581aff..e92c597d08f9faf66169493657b31071107cf
b39 100644
> --- a/WebKit/qt/ChangeLog
> +++ b/WebKit/qt/ChangeLog
> @@ -1,3 +1,12 @@
> +2010-06-07  Anders Bakken  <agbakken at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Qt] DragClientQt.h has coding-style errors
> +	   https://bugs.webkit.org/show_bug.cgi?id=40245
> +
> +	   * WebCoreSupport/DragClientQt.h:
> +
>  2010-06-06  Antonio Gomes  <tonikitoo at webkit.org>, Laszlo Gombos 
<laszlo.1.gombos at nokia.com>
>  
>	   Reviewed by Kenneth Christiansen, Eric Seidel.
> diff --git a/WebKit/qt/WebCoreSupport/DragClientQt.h
b/WebKit/qt/WebCoreSupport/DragClientQt.h
> index
4c831917c2218f514c962424eb88e6a2b014d344..08d9eb00b715c8d0c5e1fccd0014a3d19be99
251 100644
> --- a/WebKit/qt/WebCoreSupport/DragClientQt.h
> +++ b/WebKit/qt/WebCoreSupport/DragClientQt.h
> @@ -23,6 +23,8 @@
>   * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
>   */
>  
> +#ifndef DragClientQt_h
> +#define DragClientQt_h

There should be a blank line here.

>  #include "DragClient.h"

Ditto.

>  class QWebPage;

Probably here too.

>  namespace WebCore {


This isn't spelled out in the style guide but it is typical style, so as long
as you have a patch focused on style....