[webkit-reviews] review denied: [Bug 40254] [Qt] FrameLoaderClientQt.cpp has coding-style errors : [Attachment 58068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 09:19:17 PDT 2010


David Levin <levin at chromium.org> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 40254: [Qt] FrameLoaderClientQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40254

Attachment 58068: Patch
https://bugs.webkit.org/attachment.cgi?id=58068&action=review

------- Additional Comments from David Levin <levin at chromium.org>
WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:83
 +  static QString drtDescriptionSuitableForTestResult(WebCore::Frame* wframe)
wframe is an abbreviation and WebKit avoids those for variable names. Maybe
webCoreFrame would be better.


More information about the webkit-reviews mailing list