[webkit-reviews] review denied: [Bug 40228] Web Inspector: Enable serialization/deserialization of the frontend state : [Attachment 58242] [PATCH] Comments addressed, property-wise persistence introduced

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 07:54:51 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 40228: Web Inspector: Enable serialization/deserialization of the frontend
state
https://bugs.webkit.org/show_bug.cgi?id=40228

Attachment 58242: [PATCH] Comments addressed, property-wise persistence
introduced
https://bugs.webkit.org/attachment.cgi?id=58242&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorController.cpp:234
 +  void InspectorController::setFrontendProperty(const String& name, const
String& valueJSON, bool session)
valueJSON -> value

I don't think we need to require value to be JSON-stringified object.


More information about the webkit-reviews mailing list