[webkit-reviews] review denied: [Bug 40289] Web Inspector: v8 debugger should always be enabled when frontend is attached. : [Attachment 58232] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 04:48:33 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 40289: Web Inspector: v8 debugger should always be enabled when frontend is
attached.
https://bugs.webkit.org/show_bug.cgi?id=40289

Attachment 58232: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=58232&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/InspectorController.cpp:439
 +	    enableDebuggerFromFrontend(false);
This will cause all parsed scripts to be pushed to the frontend along with
their content. It may be quite expensive and currently we don't send the
sources until ScriptsPanel is shown. We should come up with something smarter
here.


More information about the webkit-reviews mailing list