[webkit-reviews] review denied: [Bug 40356] Fix handling of bytes received from the network while in document.write : [Attachment 58220] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 40356: Fix handling of bytes received from the network while in
document.write
https://bugs.webkit.org/show_bug.cgi?id=40356

Attachment 58220: Patch
https://bugs.webkit.org/attachment.cgi?id=58220&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTML5Tokenizer.cpp:126
 +		// We don't want to consume any more of the input stream now. 
Do
This is confusing.  I think you mean:
"We were just passed data off the network in a nested call to write().	We
append this data to the end, but we don't process it until we unwind to a less
nested write()." or similar.

WebCore/ChangeLog:18
 +	    tokenizer.
You should explain here how you also fixed the close() stuff to be more sane.

WebCore/html/HTML5Tokenizer.h:111
 +		    m_inputStream->m_last = &m_afterInsertionPoint;
This line is not clear to me.

WebCore/html/HTML5Tokenizer.h:117
 +		if (m_inputStream->m_last == &m_afterInsertionPoint)
This is also not clear.

I think InsertionPointRecord needs more explanation.  And the ChangeLog needs
to explain the close() stuff.  I assume you ran all the tests?