[webkit-reviews] review granted: [Bug 40052] [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT : [Attachment 58207] patch - WebKit version of WebThemeEngine v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 8 21:04:17 PDT 2010
Kent Tamura <tkent at chromium.org> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 40052: [DRT/Chromium] Upstream test_shell_webthemeengine as
WebThemeEngineDRT
https://bugs.webkit.org/show_bug.cgi?id=40052
Attachment 58207: patch - WebKit version of WebThemeEngine v2
https://bugs.webkit.org/attachment.cgi?id=58207&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebKitTools/ChangeLog:8
+ Add WebThemeEngineDRT and WebThemeControlDRT ported from Chrome
rev. 48907
nit: Chrome -> Chromium
WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.cpp:243
+ line(m_left + 1, i, m_right - 1, i, readOnlyColor);
Indentation looks worng.
WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.cpp:265
+ break;
ditto.
More information about the webkit-reviews
mailing list