[webkit-reviews] review denied: [Bug 38826] Don't convert filenames to URLs in edit drags. : [Attachment 58202] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 38826: Don't convert filenames to URLs in edit drags.
https://bugs.webkit.org/show_bug.cgi?id=38826

Attachment 58202: Patch
https://bugs.webkit.org/attachment.cgi?id=58202&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
LayoutTests/ChangeLog:14
 +	    (moveMouseToCenterOfElement):
No need to show these new methods in js.

WebCore/platform/DragData.h:81
 +	    enum ShouldConvertFilenames { DoNotConvertFilenames,
ConvertFilenames };
Might be better to name ShouldConvertFilenames as FilenamesConvertPolicy.

WebCore/platform/chromium/DragDataChromium.cpp:64
 +  String DragData::asURL(ShouldConvertFilenames convertFilenames, String*
title) const
ShouldConvertFilenames convertFilenames => FilenamesConvertPolicy convertPolicy


WebCore/platform/android/DragDataAndroid.cpp:71
 +  bool DragData::containsURL(ShouldConvertFilenames convertFilenames) const
The argument name can be omitted. Please also change other occurrences.