[webkit-reviews] review denied: [Bug 25645] SVG - numeric overflow for very large elements : [Attachment 58072] Revised (v4) patch to fix SVG number parsing of large numbers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 11:43:30 PDT 2010


Nikolas Zimmermann <zimmermann at kde.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 25645: SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645

Attachment 58072: Revised (v4) patch to fix SVG number parsing of large numbers
https://bugs.webkit.org/attachment.cgi?id=58072&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Hi W. James,

almost there! Your WebCore/ChangeLog contains unrelated entries though, you
need to remove them, before I can set r+ and cq+. Setting cq+ will auto-land
the patch for you.
I don't think you need to mention twice that you've revised the variable
naming. Just make it one statement.

Thanks for your patience,
Niko


More information about the webkit-reviews mailing list