[webkit-reviews] review granted: [Bug 39695] FrameLoader cleanup: Merge some bool members into a state machine : [Attachment 58163] Renamed to FrameLoaderStateMachine, made a mutable member
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 8 11:37:13 PDT 2010
Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 39695: FrameLoader cleanup: Merge some bool members into a state machine
https://bugs.webkit.org/show_bug.cgi?id=39695
Attachment 58163: Renamed to FrameLoaderStateMachine, made a mutable member
https://bugs.webkit.org/attachment.cgi?id=58163&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm glad to see these bool go. Thanks for the patch.
WebCore/ChangeLog:41
+ (WebCore::FrameLoader::loaderState):
These lines are out of date. Ideally, we'd update them, but it's a pain.
WebCore/loader/FrameLoaderStateMachine.h:13
+ * 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
This should say "Google"
WebCore/loader/FrameLoaderStateMachine.h:49
+ // State modifiers
I wish these were more of a flow diagram with something like an advance()
method or something.
WebCore/loader/FrameLoaderStateMachine.cpp:75
+ ASSERT(m_state == CreatingInitialEmptyDocument);
Oh, these asserts are nice. Thanks.
More information about the webkit-reviews
mailing list