[webkit-reviews] review denied: [Bug 40073] [Qt] rendering error in mediawiki : [Attachment 58162] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 11:29:02 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied adawit at kde.org's
request for review:
Bug 40073: [Qt] rendering error in mediawiki
https://bugs.webkit.org/show_bug.cgi?id=40073

Attachment 58162: Patch
https://bugs.webkit.org/attachment.cgi?id=58162&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit/qt/Api/qwebsettings.cpp:434
 +	    sites that use certain frameworks, such as the older versions of
MediaWiki, may not render properly.
I'm not sure if we really want references to MediaWiki here. Also, I do not
like "not render or display properly in it", as the case is actually that is is
a workaround for broken sites, not just sites that do not look good.

WebKit/qt/Api/qwebsettings.h:77
 +	    SiteSpecificQuirksModeEnabled
We might want a more understanding setting, Let's see what Simon says.

Apart from that, the idea is fine. R- due to semi-optimal documentation.


More information about the webkit-reviews mailing list