[webkit-reviews] review canceled: [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash : [Attachment 58148] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has canceled  review:
Bug 39879: Geolocation activity started after frame has been disconnected can
cause crash
https://bugs.webkit.org/show_bug.cgi?id=39879

Attachment 58148: Patch
https://bugs.webkit.org/attachment.cgi?id=58148&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
(In reply to comment #27)
> > I much prefer that name, but maybe AP thinks it should be left?
> 
> Yes, that function should have a "get" prefix.

You think |copyNotifiersToVector(Vector&)| is less clear than
|getNotifiersVector(Vector&)|?	I can't say I agree.
 
> > Marcus, would you mind looking at this before I submit?
> 
> Let me look over this patch in more detail, too. Given the discussion in bug
40162, we may need to spend some more time thinking about this.

I've taken away the r+ per your request, but I think leaving things in this
half-working state is worse than letting this go in and then doing subsequent
patches based on whatever resolution we come up with in that other bug.