[webkit-reviews] review granted: [Bug 39058] old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests : [Attachment 58125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 10:53:34 PDT 2010


Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 39058: old-run-webkit-tests should use ensure-valid-python to check if it
can run the websockets tests
https://bugs.webkit.org/show_bug.cgi?id=39058

Attachment 58125: Patch
https://bugs.webkit.org/attachment.cgi?id=58125&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think its good practice for all paths to be absolute, regardless of what the
current directory is.  I wouldn't bother adding the comment, but this looks
fine.


More information about the webkit-reviews mailing list