[webkit-reviews] review denied: [Bug 40259] [Qt] EventHandlerQt.cpp has coding-style errors : [Attachment 58077] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 8 10:34:36 PDT 2010
Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Anders Bakken
<agbakken at gmail.com>'s request for review:
Bug 40259: [Qt] EventHandlerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40259
Attachment 58077: Patch
https://bugs.webkit.org/attachment.cgi?id=58077&action=review
------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Please remove "(OOPS!)" from the ChangeLog and perhaps mention why there is no
new tests (e.g. "no new functionality" or "style change only").
Also I saw that you have quite a few changes up for review (with similar
problems). I think you can combine some of these into a single patch (if all
they do is style fixes for QtWebKit).
Thanks.
More information about the webkit-reviews
mailing list