[webkit-reviews] review granted: [Bug 40274] Fix script-after-frameset test in HTML5 parser : [Attachment 58143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 10:07:01 PDT 2010


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40274: Fix script-after-frameset test in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40274

Attachment 58143: Patch
https://bugs.webkit.org/attachment.cgi?id=58143&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
WebCore/html/HTML5TreeBuilder.h:65
 +	enum InsertionMode {
Sadly, this might eventually need to be public.  Let's keep it private for as
long as we can.

WebCore/html/HTML5TreeBuilder.h:77
 +	InsertionMode insertionMode() const { return m_insertionMode; }
I'm not sure these private getters/setters are needed, but ok.


More information about the webkit-reviews mailing list