[webkit-reviews] review denied: [Bug 40250] Adds IndexedDB's KeyRange. : [Attachment 58132] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 40250: Adds IndexedDB's KeyRange.
https://bugs.webkit.org/show_bug.cgi?id=40250

Attachment 58132: Patch
https://bugs.webkit.org/attachment.cgi?id=58132&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
You need to add the KeyRange.h/cpp to Android.mk + CMakeLists.txt

the idl's need to be added to derivedSrouces make and all in one files.

You also forgot the xcode project + visual
studio.WebCore/storage/IDBKeyRange.cpp:13
 +   * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
Copy the license from one of the other IDB files...the 2 clause license without
"Apple Computer" is the latest.

WebCore/storage/IDBKeyRange.cpp:40
 +	: m_left(IDBAny::create()), m_right(IDBAny::create()), m_flags(flags)
separate onto their own lines.