[webkit-reviews] review granted: [Bug 40284] Implement HTML5's forceQuirks flag : [Attachment 58115] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 00:00:06 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 40284: Implement HTML5's forceQuirks flag
https://bugs.webkit.org/show_bug.cgi?id=40284

Attachment 58115: Patch
https://bugs.webkit.org/attachment.cgi?id=58115&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/html/HTMLParser.cpp:349
 +	if (t->m_forceQuirks)
We should add some comment(s) here about how the two parsers work.  You should
reference the FIXME inside Document::addChild and how the legacy parser had
intended to move the logic out here.

How's our test coverage here?  Do we feel it's sufficient?


More information about the webkit-reviews mailing list