[webkit-reviews] review granted: [Bug 40274] Fix script-after-frameset test in HTML5 parser : [Attachment 58108] Fix tabs in ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 7 22:12:51 PDT 2010
Eric Seidel <eric at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40274: Fix script-after-frameset test in HTML5 parser
https://bugs.webkit.org/show_bug.cgi?id=40274
Attachment 58108: Fix tabs in ChangeLog
https://bugs.webkit.org/attachment.cgi?id=58108&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/ChangeLog:13
+ No new tests because covered by existing test.
You should give some example test.
WebCore/html/HTML5TreeBuilder.h:65
+ // FIXME: Move this to HTML5Parser once it is created.
There is no HTML5Parser. :) This is the right place for this.
This patch looks perfect, except for the comment.
More information about the webkit-reviews
mailing list