[webkit-reviews] review denied: [Bug 40052] [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT : [Attachment 58103] patch - WebKit version of WebThemeEngine v2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 40052: [DRT/Chromium] Upstream test_shell_webthemeengine as
WebThemeEngineDRT
https://bugs.webkit.org/show_bug.cgi?id=40052

Attachment 58103: patch - WebKit version of WebThemeEngine v2
https://bugs.webkit.org/attachment.cgi?id=58103&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.cpp:31
 +  // This file implements a simple generic version of the WebKitThemeEngine,
WebKitThemeEngine -> WebThemeEngine


WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.cpp:272
 +	    triangle(m_left,		    m_bottom,
Should m_bottom be aligned to m_bottom in the above triangle() call?


WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.cpp:292
 +	const int kCheckIndent = 3;
We don't add "k" prefix to a constant values in WebKit.


WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.h:49
 +  namespace WebKit {
DRT classes should not be in WebKit namespace.	It doesn't need any namespace.



WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.h:76
 +	    unknownState = 0,
Enum values should start with a capital letter.


WebKitTools/DumpRenderTree/chromium/WebThemeControlDRT.h:98
 +	    unknownType = 0,
ditto.


WebKitTools/DumpRenderTree/chromium/WebThemeEngineDRT.h:53
 +  namespace WebKit {
DRT classes should not have WebKit namespace.