[webkit-reviews] review granted: [Bug 39854] Refactor platform dependent editing behavior code out of Settings : [Attachment 58081] patch v2.3 - part I (agaisnt ToT and builds)

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 39854: Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

Attachment 58081: patch v2.3 - part I (agaisnt ToT and builds)
https://bugs.webkit.org/attachment.cgi?id=58081&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
This looks good to me with the nit below fixed.

WebCore/editing/Editor.cpp:104
 +	if (!m_frame || !m_frame->page() || !m_frame->settings())
Do you need to null-check page here? m_frame and settings should be sufficient.