[webkit-reviews] review denied: [Bug 25645] SVG - numeric overflow for very large elements : [Attachment 58066] Revised (v3) patch to fix SVG number parsing of large numbers

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 25645: SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645

Attachment 58066: Revised (v3) patch to fix SVG number parsing of large numbers
https://bugs.webkit.org/attachment.cgi?id=58066&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Almost there, sorry for forcing you to another iteration: LayoutTests is also
missing a ChangeLog.
A last suggestion: Can you just name the variables "left" / "top" / etc. in
enclosingIntRect(), we don't use type prefixes in variable names like "int
iFoo" / "float fFoo" in WebKit.
Can you land on your own, or do you need cq+ after I set r+ on the new patch?