[webkit-reviews] review canceled: [Bug 40228] Web Inspector: Enable serialization/deserialization of the frontend state : [Attachment 58054] [PATCH] Style fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 7 11:52:09 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has canceled Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 40228: Web Inspector: Enable serialization/deserialization of the frontend
state
https://bugs.webkit.org/show_bug.cgi?id=40228
Attachment 58054: [PATCH] Style fixed
https://bugs.webkit.org/attachment.cgi?id=58054&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
We are using same control flow / data structures for the "FrontendSettings" and
"SessionProperties". Furthermore, data structure is called Settings on the
front-end side. I think we should align the naming better. I realize that
'settings' is not the best name for the session store, but I don't like the way
you name the new thing. Rest of the patch seems to be fine. Clearing r? flag
while I am thinking of the better names. Please think about it too and suggest
things!
More information about the webkit-reviews
mailing list