[webkit-reviews] review requested: [Bug 39966] Crash in qsort() because compareBorders() is not reliable : [Attachment 58041] Fixed bugs. use same function for both qsort and other cases
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 7 10:03:56 PDT 2010
Yong Li <yong.li.webkit at gmail.com> has asked for review:
Bug 39966: Crash in qsort() because compareBorders() is not reliable
https://bugs.webkit.org/show_bug.cgi?id=39966
Attachment 58041: Fixed bugs. use same function for both qsort and other cases
https://bugs.webkit.org/attachment.cgi?id=58041&action=review
------- Additional Comments from Yong Li <yong.li.webkit at gmail.com>
Also fixed a bug in the old function: when both borders have NONE style, it
didn't continue comparing any more. But it should continue checking other
properties in this case according to the comment:
// (2) Borders with a style of 'none' have the lowest priority. Only if the
border properties of all
// the elements meeting at this edge are 'none' will the border be omitted (but
note that 'none' is
// the default value for the border style.)
// (3) If none of the styles are 'hidden' and at least one of them is not
'none', then narrow borders
More information about the webkit-reviews
mailing list