[webkit-reviews] review canceled: [Bug 40228] Web Inspector: Enable serialization/deserialization of the frontend state : [Attachment 58030] [PATCH] Fixed compilability on mac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 08:35:43 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has canceled Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 40228: Web Inspector: Enable serialization/deserialization of the frontend
state
https://bugs.webkit.org/show_bug.cgi?id=40228

Attachment 58030: [PATCH] Fixed compilability on mac
https://bugs.webkit.org/attachment.cgi?id=58030&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorBackend.idl:38
 +	    void saveFrontendSession(in DOMString sessionData);
I would introduce a setSessionProperty (with corresponding push method on
front-end) instead. You can use new InspectorValue class as a dictionary that
can be JSON-stringified.


More information about the webkit-reviews mailing list