[webkit-reviews] review denied: [Bug 39902] [Qt] QtWebKit does not support viewport meta tag : [Attachment 57704] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 39902: [Qt] QtWebKit does not support viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=39902

Attachment 57704: Patch
https://bugs.webkit.org/attachment.cgi?id=57704&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Ok, let's continue with the review.

WebKit/qt/Api/qwebframe_p.h:102
 +	bool hasPassedLayoutPhase;
I kind of like the term "initialLayoutComplete", similar to void
FrameLoaderClientQt::dispatchDidFirstLayout()

AFAICS this is entirely an optimization to avoid a double initial layout,
right?

WebKit/qt/Api/qwebpage.cpp:2213
 +	Setting an invalid size, makes the page fall back to using the viewport
for layout.
Suggestion: "using the viewport for layout" -> "using the viewport size for
layout"

WebKit/qt/Api/qwebpage.h:197
 +	struct ViewportHints {
I suggest to make the constructor non-inline, prefix the member variables with
m_, provide inline getters, add a non-inline destructor, copy constructor and
assignment operator. In addition I suggest to add a ViewportHintsPrivate* d;
for future-proofing.

So that by default the structure is created using one function call and one
initial allocation, but we _can_ extend it in the future without breaking
binary or source compatibility.

WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:397
 +	emit
m_webFrame->page()->viewportChangeRequested(QWebPage::ViewportHints());
Hmm, this is used to "reset" the scale in the browser, right?

It's kind of ugly. I guess it could be made prettier if the docs of the signal
explain that this is going to happen and we could have a isValid() or so in the
structure.