[webkit-reviews] review requested: [Bug 40231] Add native call support for ARM and Thumb-2 JIT with JSValue32 : [Attachment 58020] Add native call support for ARM and Thumb-2 JIT with JSValue32.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 06:09:33 PDT 2010


Gabor Loki <loki at webkit.org> has asked	for review:
Bug 40231: Add native call support for ARM and Thumb-2 JIT with JSValue32
https://bugs.webkit.org/show_bug.cgi?id=40231

Attachment 58020: Add native call support for ARM and Thumb-2 JIT with
JSValue32.
https://bugs.webkit.org/attachment.cgi?id=58020&action=review

------- Additional Comments from Gabor Loki <loki at webkit.org>
Same technique was used as on x86_64 with some limitations.
- we cannot use regT0 for the new callframe, because r0 (=regT0) should be the
first argument of the host function.
- a callee preserved register should be used to hold the return address instead
of the stack.
- preserveReturnAddressAfterCall/restoreReturnAddressBeforeReturn functions
should be used to work with return address (instead of peek/poke on stack).


More information about the webkit-reviews mailing list