[webkit-reviews] review denied: [Bug 37772] WebGL rendering context does not activate unless accelerated compositing is enabled from settings. : [Attachment 53861] Allows creation of WebGL rendering context if webGLEnabled flag is true and does not also require acceleratedCompositing flag also to be true.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 04:10:45 PDT 2010


Simon Hausmann <hausmann at webkit.org> has denied Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 37772: WebGL rendering context does not activate unless accelerated
compositing is enabled from settings.
https://bugs.webkit.org/show_bug.cgi?id=37772

Attachment 53861: Allows creation of WebGL rendering context if webGLEnabled
flag is true and does not also require acceleratedCompositing flag also to be
true.
https://bugs.webkit.org/attachment.cgi?id=53861&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
It does not appear that this patch takes Chris' commen into account:

"The Mac implementation requires acceleratedCompositing for WebGL rendering.
It's reasonable to remove the test for acceleratedCompositing here as long as,
for the Mac platform, webGLEnabled has a test to prevent it from being true
unless acceleratedCompositing is also true."

So landing this fix would re-open Bug 35759


More information about the webkit-reviews mailing list