[webkit-reviews] review denied: [Bug 40217] [Mac] <meter> elements should be rendered as level indicators. : [Attachment 57993] patch v0

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 40217: [Mac] <meter> elements should be rendered as level indicators.
https://bugs.webkit.org/show_bug.cgi?id=40217

Attachment 57993: patch v0
https://bugs.webkit.org/attachment.cgi?id=57993&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
Would you split the patch, please?  I think "enabling ENABLE_METER_TAG on Mac"
can be another patch.


WebCore/rendering/RenderMeter.h:36
 +	double min() const;
RenderTheme* may access HTMLMeterElement.  So these functions are not needed in
RenderMeter.


WebCore/rendering/RenderThemeMac.mm:834
 +  RenderThemeMac::LevelType RenderThemeMac::levelTypeFor(const RenderMeter*
renderMeter) const
This operation is not Mac-specific.  LevelType symbols should be HTML5-like
(optimum, suboptimal, even-less-good) and the function should be in
HTMLMeterElement.