[webkit-reviews] review denied: [Bug 39083] Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder : [Attachment 57922] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Kinuko Yasuda <kinuko at chromium.org>'s
request for review:
Bug 39083: Refactor FormData and Blob for better support of Blobs synthesized
by BlobBuilder
https://bugs.webkit.org/show_bug.cgi?id=39083

Attachment 57922: Patch
https://bugs.webkit.org/attachment.cgi?id=57922&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Looks generally good. Just several more comments.

WebCore/ChangeLog:9
 +	      FormDataList and makes Blob as a collection of BlobItems.
The 2nd part after "and" seems to be redundant.

WebCore/ChangeLog:49
 +	    (WebCore::FormDataList::appendString):
Please also mention here that the line ending fix logic has been moved to
StringBlobItem::convertToCString.

WebCore/platform/network/FormData.cpp:217
 +	    const RefPtr<BlobItem> value = items[i + 1];
Might be better to use "const BlobItem*" in order to be consistent with
previous line.

WebCore/platform/network/FormData.h:23
 +  #include "BlobItem.h"
It seems that we do not need to include BlobItem.h. Instead we can add forward
reference to BlobItem and BlobItemList.

WebKit/chromium/src/WebSearchableFormData.cpp:201
 +	      if (!item)
Is there any case that the current item is not StringBlobItem? I think we
rather throw ASSERT here.