[webkit-reviews] review requested: [Bug 39854] Refactor platform dependent editing behavior code out of Settings : [Attachment 57916] patch v2.3 - part I

[bugzilla-daemon at webkit.org]

Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 39854: Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854

Attachment 57916: patch v2.3 - part I
https://bugs.webkit.org/attachment.cgi?id=57916&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
As per suggestion in comment #32, patch "v2.3 - part I" introduces the
following methods to EditingBehavior.h:

bool shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom() const { ... }
bool shouldCenterAlignWhenSelectionIsRevealed() const { ... }
bool shouldConsiderMouseSelectionAsDirectional() const { ... }

Follow up work will replace all remaining calls to Editing{Mac,Windows}Behavior
by new functions in EditingBehavior class.

remaing ones, currently bad named are:

(these are close imo)
bool shouldConsiderStylePresentOnlyIfThroughoutTheSelection() const { ... }
bool shouldExtendSelectionFromEndPointAlways() const { ... }

(these need love)
bool shouldKeybardSelectionExtendForHorizontalNavigation() const { ... }
bool shouldGrowSelectionWhenExtendingToBoundary() const { ...}