[webkit-reviews] review denied: [Bug 40172] HTML5 parser should be within 1% of old parser performance : [Attachment 57893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 10:43:35 PDT 2010


Darin Adler <darin at apple.com> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 40172: HTML5 parser should be within 1% of old parser performance
https://bugs.webkit.org/show_bug.cgi?id=40172

Attachment 57893: Patch
https://bugs.webkit.org/attachment.cgi?id=57893&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks like this doesn't compile either because of distinct Vector types. To
assign between vectors, currently the inline capacities need to be identical.
Also, it's likely to be inefficient to assign between vectors with inline
capacities since the characters need to be copied. We could add code to make
assignment between vectors with different inline capacities possible, but it
might be worth looking at a design that to uses pointers a bit more so that is
not needed.


More information about the webkit-reviews mailing list