[webkit-reviews] review granted: [Bug 40054] [indexedDB] It is impossible to create object stores : [Attachment 57882] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 40054: [indexedDB] It is impossible to create object stores
https://bugs.webkit.org/show_bug.cgi?id=40054

Attachment 57882: Patch
https://bugs.webkit.org/attachment.cgi?id=57882&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
WebCore/ChangeLog:12
 +	    * Android.mk:
regenerate list

WebCore/storage/IndexedDatabaseRequest.cpp:57
 +	    // FIXME: make this work with workers.
ASSERT_NOT_REACHED()
WebCore/storage/IndexedDatabaseRequest.cpp:63
 +	    return 0;
Didn't we agree to return an IDBRequest that'll just never fire?

WebCore/storage/IndexedDatabaseRequest.cpp:61
 +	Document* doc = static_cast<Document*>(context);
don't abbreviate 

WebKit/chromium/public/WebIDBDatabase.h:64
 +	    WEBKIT_ASSERT_NOT_REACHED();
Might be slightly better to assign the WebIDBCallbacks to an OwnPtr so you
don't leak and to make it obvious to whomever implements this that it's an
owning relationship...but this code is going away soon anyway so I don't care
much.