[webkit-reviews] review denied: [Bug 40162] Prevent Geolocation making callbacks to a ScriptExecutionContext that no longer exists : [Attachment 57865] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 06:41:08 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 40162: Prevent Geolocation making callbacks to a ScriptExecutionContext
that no longer exists
https://bugs.webkit.org/show_bug.cgi?id=40162

Attachment 57865: Patch
https://bugs.webkit.org/attachment.cgi?id=57865&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
LayoutTests/ChangeLog:8
 +	    * fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
Added.
This is the only one that showed up in the diff.

WebCore/ChangeLog:6
 +	    https://bugs.webkit.org/show_bug.cgi?id=40162
All the detail in the bug should be here as well.

I'm fine with doing this change then looking at doing ActiveDOMObject, but I
still think the latter should be done.


More information about the webkit-reviews mailing list