[webkit-reviews] review requested: [Bug 39149] Canvas element cannot have negative width or height : [Attachment 57867] Proposed patch v4

[bugzilla-daemon at webkit.org]

Andreas Kling <andreas.kling at nokia.com> has asked  for review:
Bug 39149: Canvas element cannot have negative width or height
https://bugs.webkit.org/show_bug.cgi?id=39149

Attachment 57867: Proposed patch v4
https://bugs.webkit.org/attachment.cgi?id=57867&action=review

------- Additional Comments from Andreas Kling <andreas.kling at nokia.com>
Updated patch with additional test coverage.
The spec isn't too explicit on how NaN/etc should be handled.
NaN/Infinity/null becomes 0 on Firefox and 300/150 (default value) on Opera.
Opera OTOH doesn't allow 0 width/height.
Personally, while I think mapping NaN/Infinity/null to the default values makes
some sense,
it doesn't justify adding custom JS bindings to deal with these cases.