[webkit-reviews] review denied: [Bug 40158] ASSERTION FAILED with -webkit-appearance:progress-bar for non-progress bar elements : [Attachment 57855] patch v1; attempt to chromium build fix

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 40158: ASSERTION FAILED with -webkit-appearance:progress-bar for
non-progress bar elements
https://bugs.webkit.org/show_bug.cgi?id=40158

Attachment 57855: patch v1; attempt to chromium build fix
https://bugs.webkit.org/attachment.cgi?id=57855&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
LayoutTests/fast/css/script-tests/invalid-appearance-progress-bar-meter.js:3
 +  var body = document.getElementsByTagName("body")[0];
document.body is simpler.


WebCore/rendering/RenderTheme.cpp:47
 +  #import "RenderProgress.h"
Why #import instead of #include ?


WebCore/rendering/RenderTheme.h:245
 +	virtual bool paintMeter(RenderMeter*, const RenderObject::PaintInfo&,
const IntRect&);
For consistency with other paint*() member functions, I prefer not changing the
parameter types, and check isMeter() and isProgress() in their paint*()
functions.