[webkit-reviews] review granted: [Bug 39494] Change filenameFromString to return CString : [Attachment 56844] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 02:01:29 PDT 2010


Kent Tamura <tkent at chromium.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 39494: Change filenameFromString to return CString
https://bugs.webkit.org/show_bug.cgi?id=39494

Attachment 56844: Revised patch
https://bugs.webkit.org/attachment.cgi?id=56844&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
> I tried to be consistent as two other functions use "WTF::" prefix here:

That's reasonable.
Style errors came from the existing code. So, this patch looks OK.


More information about the webkit-reviews mailing list