[webkit-reviews] review canceled: [Bug 40077] [Qt] Implement the simple font code path. : [Attachment 57683] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has canceled Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 40077: [Qt] Implement the simple font code path.
https://bugs.webkit.org/show_bug.cgi?id=40077

Attachment 57683: Patch
https://bugs.webkit.org/attachment.cgi?id=57683&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Changes:
- Fixed style and compilation issues
- Changed the complex-calls-inside-the-simple-functions to Q_ASSERT(false) to
avoid confusion. These function should not be called anyway since we called
setCodePath in QWebPagePrivate::QWebPagePrivate()
- Merge the two drawText functions in one function to fix compilation issues.
The readability takes a drop but I think it is better than duplicating the text
shadow/pen/brush logic.
- gRoundingHackCharacterTable and stuff is still wrapped in "#if !PLATFORM(QT)"
to save 256 bytes, I'm not sure it's worth it though.