[webkit-reviews] review granted: [Bug 40136] webkit-patch upload doesn't show diff on cygwin : [Attachment 57808] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 18:23:03 PDT 2010


Adam Barth <abarth at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 40136: webkit-patch upload doesn't show diff on cygwin
https://bugs.webkit.org/show_bug.cgi?id=40136

Attachment 57808: Patch
https://bugs.webkit.org/attachment.cgi?id=57808&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks reasonable.  Generally, we don't have a good strategy for testing things
in user.py.  In fact, that file exists to abstract away things that we don't
know how to test.


More information about the webkit-reviews mailing list