[webkit-reviews] review denied: [Bug 38492] CG implementation needed for compression quality in canvas.toDataURL : [Attachment 57838] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Matthew Delaney <mdelaney at apple.com>'s
request for review:
Bug 38492: CG implementation needed for compression quality in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=38492

Attachment 57838: Patch
https://bugs.webkit.org/attachment.cgi?id=57838&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
In the Qt version you don't do a range check on the quality value passed in.
But in the CG version you do. And you removed the checking from the custom
binding for toDataURL. This means that the Qt version won't have range checking
any more, but it did before.

review- because you should not regress Qt in this fashion. Otherwise, r=me