[webkit-reviews] review requested: [Bug 40004] [Qt] Support for loading notification icons : [Attachment 57798] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 12:06:54 PDT 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 40004: [Qt] Support for loading notification icons
https://bugs.webkit.org/show_bug.cgi?id=40004

Attachment 57798: Patch
https://bugs.webkit.org/attachment.cgi?id=57798&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
If the icon url exists, create a ThreadableLoader to handle loading the icon,
and keep the notification in a load queue.
Once the icon is loaded, or an error occurred, move the notification to the
active queue and continue handling as before.

Added some more lookup logic for the second queue. If reviewers prefer, I will
create a template for that logic, to reduce the amount of code.


More information about the webkit-reviews mailing list