[webkit-reviews] review granted: [Bug 40129] Geolocation needs LayoutTest to test making callbacks to remote frames : [Attachment 57787] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 40129: Geolocation needs LayoutTest to test making callbacks to remote
frames
https://bugs.webkit.org/show_bug.cgi?id=40129

Attachment 57787: Patch
https://bugs.webkit.org/attachment.cgi?id=57787&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that tests like this should be script-tests. That doesn't improve
anything, but has very real costs - for example, I can't just open a test and
see what it does, as I need to open related .js file in a subdirectory instead.


Also, it's more difficult to share tests that utilize complicated support
libraries with engineers working on other engines, so it's less likely that
they will run our tests and be compatible with us.

And you had to resort to DOM manipulation just to add an iframe element.

It would be useful to also have a test that calls getCurrentPosition() directly
from iframe, not from a function defined in main frame's document.

r=me