[webkit-reviews] review denied: [Bug 40080] Web Inspector: better Function.prototype.bind for the internal code : [Attachment 57700] Show a handler function instead of Function.prototype.bind
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 3 03:11:54 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied review:
Bug 40080: Web Inspector: better Function.prototype.bind for the internal code
https://bugs.webkit.org/show_bug.cgi?id=40080
Attachment 57700: Show a handler function instead of Function.prototype.bind
https://bugs.webkit.org/attachment.cgi?id=57700&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Clearing r+ since Nikita won't be able to land it with modifications anyways
(he is not yet a committer).
WebCore/inspector/front-end/utilities.js:58
+ function bound() {
Please move { to the next line.
Also, I am not a fan of this change - it improves things for Web Inspector, but
leaves rest of the web developers suffering. None of the major frameworks do
this trick for the bind.
In fact, there already is something that could become a standard: see
https://bugs.webkit.org/show_bug.cgi?id=25171. I don't like it much, but it is
already there. I'd rather support displayName in event listeners list and set
in bind to be consistent.
Ideal solution to my taste is when we infer the name from the closure. It is
hard though.
More information about the webkit-reviews
mailing list