[webkit-reviews] review granted: [Bug 40088] webkit-patch should use a different editor env variable to avoid conflicting with prepare-ChangeLog : [Attachment 57714] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 2 16:35:26 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 40088: webkit-patch should use a different editor env variable to avoid
conflicting with prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=40088
Attachment 57714: Patch
https://bugs.webkit.org/attachment.cgi?id=57714&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Why is it _APPLICATION? Seems should just be _EDITOR since it's actually a
terminal program. xed --launch --wait just is a terminal program which watches
XCode.
Otherwise LGTM.
More information about the webkit-reviews
mailing list