[webkit-reviews] review requested: [Bug 39123] Unneeded fillRect call in RenderBoxModelObject::paintFillLayerExtended : [Attachment 57679] Added comments to proposed patch. Removed Color.isValid check
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 2 12:12:56 PDT 2010
Pat Galizia <pgalizia at codeaurora.org> has asked for review:
Bug 39123: Unneeded fillRect call in
RenderBoxModelObject::paintFillLayerExtended
https://bugs.webkit.org/show_bug.cgi?id=39123
Attachment 57679: Added comments to proposed patch. Removed Color.isValid check
https://bugs.webkit.org/attachment.cgi?id=57679&action=review
------- Additional Comments from Pat Galizia <pgalizia at codeaurora.org>
Added comments to code explaining why we're making the check. Also removed the
isValid() check, since that wasn't necessary.
Code seems to give a very minor performance boost to small devices, but seems
to do nothing for anything above that. No regressions detected.
More information about the webkit-reviews
mailing list