[webkit-reviews] review granted: [Bug 39918] REGRESSION(58615): Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar : [Attachment 57399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 2 11:32:15 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Nico Weber
<thakis at chromium.org>'s request for review:
Bug 39918: REGRESSION(58615): Scroll events are sent twice per keypress for
ports that don't have a platformWidget scrollbar
https://bugs.webkit.org/show_bug.cgi?id=39918

Attachment 57399: Patch
https://bugs.webkit.org/attachment.cgi?id=57399&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +    void scrollPositionChanged();
> +    virtual void repaintFixedElementsPostScroll();

We don't use the term "postScroll" anywhere else, but we do use
"afterScrolling", so I suggest you change the method name to use that.


More information about the webkit-reviews mailing list