[webkit-reviews] review granted: [Bug 39953] Web Inspector: support "Continue to Here" in debugger : [Attachment 57651] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 39953: Web Inspector: support "Continue to Here" in debugger
https://bugs.webkit.org/show_bug.cgi?id=39953

Attachment 57651: Patch
https://bugs.webkit.org/attachment.cgi?id=57651&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Overall, this looks good, so I am open to landing this. However, the change
uncovers some problems with our design in the area of passing numerous
callbacks into SourceFrame.
As we discussed offline, I would suggest the following refactorings:
1. Make SourceFrame BreakpointManager's listener
1.1. Make SourceFrame responsible for filling breakpoints on creation (few
addBreakpoint snippets will go away from ScriptsPanel)
2. Remove sourceFrameForScriptOrResource from the scripts panel.