[webkit-reviews] review denied: [Bug 40026] Web Inspector: add test for resource parameters. : [Attachment 57647] [PATCH] Rebased to HAR basis, brushed up rendering of objects.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 2 06:29:54 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 40026: Web Inspector: add test for resource parameters.
https://bugs.webkit.org/show_bug.cgi?id=40026

Attachment 57647: [PATCH] Rebased to HAR basis, brushed up rendering of
objects.
https://bugs.webkit.org/attachment.cgi?id=57647&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
LayoutTests/http/tests/inspector/inspector-test.js:63
 +	    for (var i = 0; i < result.length; ++i)
Would be nice to have it formatted like objects above with opening and closing
[]

LayoutTests/http/tests/inspector/resource-parameters.html:11
 +	    if (result === "enabling")
If resource tracking was off the callback is invoked only with "enabling"
result and will never learn that resource tracking has been enabled.


More information about the webkit-reviews mailing list