[webkit-reviews] review requested: [Bug 39041] Move the code that should be shared by sync and async DBs to a separate class : [Attachment 57643] patch #3: Move the reusable code from Database to AbstractDatabase
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 2 04:23:23 PDT 2010
Dumitru Daniliuc <dumi at chromium.org> has asked for review:
Bug 39041: Move the code that should be shared by sync and async DBs to a
separate class
https://bugs.webkit.org/show_bug.cgi?id=39041
Attachment 57643: patch #3: Move the reusable code from Database to
AbstractDatabase
https://bugs.webkit.org/attachment.cgi?id=57643&action=review
------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
patch #3 has mostly mechanical changes, with a couple of exceptions:
1. guidToDatabaseMap() was removed from Database.cpp; it wasn't used by
anybody.
2. Database::close() was changed to be callable from any thread by moving the
logic from WebKit/chromium/src/WebDatabase.cpp there.
All storage/ and fast/workers/storage/ layout tests passed.
More information about the webkit-reviews
mailing list