[webkit-reviews] review denied: [Bug 21937] h1:first-letter is incorrectly inherited by run-in box : [Attachment 57313] Proposed Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has denied Yoshiki Hayashi
<yhayashi at google.com>'s request for review:
Bug 21937: h1:first-letter is incorrectly inherited by run-in box
https://bugs.webkit.org/show_bug.cgi?id=21937

Attachment 57313: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=57313&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good, but putting r- for minor issues.

I've noticed that with the following HTML

<style type="text/css">
  h1:first-letter {text-transform: uppercase;}
</style>
<h1 style="display:run-in;">capitalized</h1><div>downcase</div>

the text "capitalized" isn't capitalized even with this patch. Is this issue
related to this bug? Or, should we file another bug to resolve this issue?


I think this patch depends on the patch in Bug 39863 so we should not land this
patch without fixing Bug 39863. For such cases, please set commit-queue- to
tell reviewers/committers that this patch should not be landed.


LayoutTests/ChangeLog:8
 +	    Need a short description and bug URL (OOPS!)
This line should be gone.

WebCore/ChangeLog:8
 +	    Need a short description and bug URL (OOPS!)
Unnecessary. Or, you might want to describe something.

LayoutTests/fast/css/first-letter-after-run-in.html:18
 +  <div class="run-in">run-in</div><div class="upper">test</div>
I would say

<div class="run-in">not-capitalized</div><div class="upper">capitalized</div>

or something like this so we can remove the description about the expectation
("If you see...")