[webkit-reviews] review denied: [Bug 40046] Compilation error when you disable DRAG SUPPORT. : [Attachment 57629] Fix compilation when DRAG_SUPPORT disabled

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied deepak <deepak.m at allaboutif.com>'s
request for review:
Bug 40046: Compilation error when you disable DRAG SUPPORT.
https://bugs.webkit.org/show_bug.cgi?id=40046

Attachment 57629: Fix compilation when DRAG_SUPPORT disabled
https://bugs.webkit.org/attachment.cgi?id=57629&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> 2010-06-02  Deepak Mundra  <deepak.m at allaboutif.com>
> 
>	  Reviewed by NOBODY (OOPS!).
> 
>	  Fix compilation, when you disable DRAG SUPPORT.
>	  ENABLE(DRAG_SUPPORT) wrappers were missing in
WebCore/page/gtk/EventHandlerGtk.cpp.

The general idea looks great, but this patch isn't well formed, so it doesn't
apply on the bots and it wouldn't go through using the commit queue.

It looks like you may have a ChangeLog but the file that it applies to is not
in the patch. If you need help preparing your patch, please see
http://webkit.org/coding/contributing.html.

Note that this ChangeLog is missing a *bug link* which is also typical for
ChangeLog entries.


when you put the patch up for review again, consider marking it commit-queue?
so that the reviewer will also mark it as commit-queue+ and it will get
committed for you.