[webkit-reviews] review denied: [Bug 39026] Recognize async attribute on script tags : [Attachment 57612] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Tony Gentilcore <tonyg at chromium.org>'s
request for review:
Bug 39026: Recognize async attribute on script tags
https://bugs.webkit.org/show_bug.cgi?id=39026

Attachment 57612: Patch
https://bugs.webkit.org/attachment.cgi?id=57612&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems at least the SVG part of this change is untested.

This test could be much simpler using a little document.write().  Since then
you could have a function which writes a script tag with a specific ID and then
returns the .async value.

testAsyncValue("ASYNC")

function testAsyncValue(async_value)
{
    var scriptId = "test" + testNumber;
    document.write("<script id='" + scriptId + "' src='ignored.js' async='" +
async_value + "'></scr" + "ipt>");
    scriptElement = document.getElementById(scriptId);
    testNumber++;
    return scriptElement.async;
}

or something like that.  You can document.write to an iframe if that works
nicer.

r- for lack of SVG testing.